stylecop Issue Tracker Rss Feed

Commented Unassigned: StyleCop has been hacked [7533]

PauloMorgado — Sat, 18 May 2013 10:50:45 GMT

http://www.stylecop.com/docs/replica-designer-handbags.asp

This url has been hacked by a company selling bags.
Comments: Doesn't seem so.

Closed Unassigned: StyleCop has been hacked [7533]

andyr — Fri, 17 May 2013 15:21:43 GMT

http://www.stylecop.com/docs/replica-designer-handbags.asp

This url has been hacked by a company selling bags.
Comments: fixed

Commented Unassigned: StyleCop has been hacked [7533]

andyr — Fri, 17 May 2013 15:21:35 GMT

http://www.stylecop.com/docs/replica-designer-handbags.asp

This url has been hacked by a company selling bags.
Comments: fixed

Created Unassigned: readonly static property [7534]

fatihtatoglu — Fri, 17 May 2013 15:08:13 GMT

Hi everyone,

I meet a warning about readonly and static property. I am using StyleCop 4.7.44.0 The warning is attached to post.

Created Unassigned: StyleCop has been hacked [7533]

ownagevids — Fri, 17 May 2013 13:48:53 GMT

http://www.stylecop.com/docs/replica-designer-handbags.asp

This url has been hacked by a company selling bags.

Commented Unassigned: Latest StyleCop constantly crashes on VS 2012 Update 2 [7520]

ekuns — Tue, 14 May 2013 17:08:14 GMT

After installing recent Update for Visual Studio 2012 - http://www.microsoft.com/en-us/download/details.aspx?id=38188 StyleCop started to crash studio often. On my box I get consistent crash on 'Go to issue via double click' and I get often crashes on ''run StyleCop on project'.
Comments: I am running into this same problem. Visual Studio is becoming unusable due to StyleCop crashing it. This appears to be caused by having a local stylecop settings file that has "merge with the following settings file" selected and pointing to a file not in a parent directory. If I manually copy the configuration everywhere, I don't get as many crashes -- but then I have to manually update a dozen copies of the same file because TFS doesn't understand how to make a link.

Commented Issue: Custom dictionary relative path [7435]

dtcoder — Mon, 13 May 2013 01:19:07 GMT

Is it possible to change the custom dictionary relative path to be relative to the settings file rather than the file currently being analysed? I presume that if this change were made, the current behaviour could be recreated by placing a settings file into the appropriate subfolder.

I suspect that in general there would be a single custom dictionary per solution, and a relative path could become tedious if its based off the analysed file.

cf: http://stylecop.codeplex.com/workitem/7422

Thanks.
Comments: VS2010 "Add As Link" feature only allows the link to be added once in a C# project. It cannot be added at each level of the folder tree. As such, the links only work for files in the root of the C# project. Spell checking in subfolders ignores the linked custom dictionary, resulting in large numbers of static analysis warnings.

Commented Issue: Custom dictionary relative path [7435]

dtcoder — Mon, 13 May 2013 01:16:04 GMT

Is it possible to change the custom dictionary relative path to be relative to the settings file rather than the file currently being analysed? I presume that if this change were made, the current behaviour could be recreated by placing a settings file into the appropriate subfolder.

I suspect that in general there would be a single custom dictionary per solution, and a relative path could become tedious if its based off the analysed file.

cf: http://stylecop.codeplex.com/workitem/7422

Thanks.
Comments: Prior to StyleCop 4.7.44, we were able to use "Add As Link" feature of Visual Studio to have just one CustomDictionary.xml file that was shared by multiple C# projects. This process is described at [MSDN: How to: Customize the Code Analysis Dictionary ](http://msdn.microsoft.com/en-us/library/bb514188(v=vs.100).aspx) in the section near the bottom titled "To apply a custom dictionary to a project". Most Relevant Excerpt: "3.To add a dictionary that is shared among two or more projects, locate the file to share in the Add Existing Item dialog box, click the down arrow on the Add button and then click Add As Link." This no longer works in StyleCop 4.7.44.

Created Unassigned: "Suppress Message" menu item not found in Error List window. [7532]

VictorWoo — Fri, 10 May 2013 05:49:16 GMT

![Image](http://blogs.msdn.com/photos/fxcop/images/1349580/original.aspx)

I can't find this "Suppress Message" menu item in Visual Studio 2012 + StyleCop 4.7
Where is it now?

http://blogs.msdn.com/b/codeanalysis/archive/2006/12/28/faq-what-is-the-globalsuppressions.cs-globalsuppressions.vb-file-and-why-is-it-needed-is-it-possible-to-change-the-name-of-this-file-david-kean.aspx

Created Unassigned: Split SA1101 based on element type [7531]

smibe — Wed, 08 May 2013 02:03:38 GMT

It would be nice to have different rules for using the this prefix based on element types: field, property, method.
I would like to enforce the 'this' prefix only when it is relevant: for fields using PascalCase. All other members are using CamelCase and for them it is pretty clear, that they are members of the class. The 'this' prefix here is obsolete.

Commented Feature: Split SA1600 into multiple rules based on the type [6981]

brettveenstra — Fri, 03 May 2013 15:37:46 GMT

Is it possible to split SA1600 into multiple rules based on the type? I would like to be able to tell style cop that undocumented public class declarations are errors, but constructors and public
methods would are only warnings or hints.
Comments: Can I get some direction on how to implement this? Would like to help and get this item resolved.

Created Unassigned: SA1650 Words with minus sign are not recognized in custom dictionary [7530]

antiohne — Wed, 01 May 2013 19:34:29 GMT

In my solution I have a Custom Dictionary for the words in summary tags which are standard not recognized. Some of these words use a minus sign, for example "HIV-virus". These kind of words are not recognized if I put them in the code analysis custom dictionary. I still get a "SA1650: CSharp.Documentation: The documentation text within the summary tag contains incorrectly spelled words: HIV-virus" warning.

Created Unassigned: SA1208 when using SystemWrapper import [7529]

trencherman — Wed, 01 May 2013 09:35:27 GMT

When using the SystemWrapper component and other non Microsoft components StyleCop complains with a SA1208 : CSharp.Ordering : System using directives must be placed before all other using directives.

This is an example of the usings after they have been sorted by Visual Studio. Stylecop then complains about SystemWrapper and SystemWrapper.IO being out of sequence with the SA1208:

using System;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
using System.Xml;
using System.Xml.Serialization;
using System.Xml.Xsl;
using log4net;
using OurSystemWrapper;
using SystemWrapper;
using SystemWrapper.IO;

It would appear that StyleCop is seeing SystemWrapper as a System.xxxxx component when it's not.

Commented Unassigned: Add support for Resharper 8 [7528]

mightymuke — Sun, 28 Apr 2013 18:27:39 GMT

Currently, Resharper 8 is in EAP state. Please add support for R# 8 to the StyleCop plugin.
Comments: see https://stylecop.codeplex.com/workitem/7508

Created Unassigned: Add support for Resharper 8 [7528]

CarstenSchuette — Sun, 28 Apr 2013 16:11:12 GMT

Currently, Resharper 8 is in EAP state. Please add support for R# 8 to the StyleCop plugin.

Created Unassigned: SA1101 not firing when instance has same name as class. [7527]

rusitzky — Thu, 25 Apr 2013 17:41:50 GMT

If you have a property with the same name as the class it's in, StyleCop (4.7.44.0) does not warn about the missing "this." Here's an example piece of code:

```
namespace StyleCopThisProblem
{
using System.Text;

/// <summary>
/// My Class
/// </summary>
public class MyClass
{
/// <summary>
/// Initializes a new instance of the <see cref="MyClass"/> class.
/// </summary>
public MyClass()
{
StringBuilder = new StringBuilder();

StringBuilderA = new StringBuilder();
}

/// <summary>
/// Gets or sets the string builder with the same name as the Class.
/// </summary>
/// <value>
/// The string builder.
/// </value>
public StringBuilder StringBuilder { get; set; }

/// <summary>
/// Gets or sets the string builder with a different name than the Class.
/// </summary>
/// <value>
/// The string builder.
/// </value>
public StringBuilder StringBuilderA { get; set; }
}
}
```
In the constructor, you get the SA1101 warning for "StringBuilderA", but not for "StringBuilder".

Created Unassigned: Nested await spacing inconsistent with Format Document [7526]

breyed — Tue, 23 Apr 2013 19:41:43 GMT

Consider a nest await expression, such as this:
```
await (await task).SomethingAsync()
```

Visual Studio's default formatting (using Format Document) places a space before the left parenthesis. However, that space triggers "SA1008 : CSharp.Spacing : Invalid spacing around the opening parenthesis."

The space should not trigger a warning.

Created Unassigned: Syntax error with C# pointer [7525]

GillesTourreau — Tue, 23 Apr 2013 17:05:16 GMT

The following code snippet display a SA0102 error :

```
Type t = typeof(void*);
```

The error message is :
> SA0102: CSharp.CsParser : A syntax error has been discovered in file ........

Commented Issue: SA1311: Warning should not be shown on private static readonly varibales [7314]

PauloMorgado — Tue, 23 Apr 2013 13:06:24 GMT

Commented Issue: SA1311: Warning should not be shown on private static readonly varibales [7314]

davedev — Mon, 22 Apr 2013 19:50:07 GMT

The following code is marked by SA1311 rule:

private static readonly Dictionary<Type, IProvider> providerInstances = new Dictionary<Type, IProvider>();

I think this is wrong, because the field is static readonly, but it's private. Only public static fields should start with an upper case letter. Or am I wrong?
Comments: Just voicing my opinion: I disagree with the conclusion as well. For example, it doesn't make sense to have a warning on a private static field that backs a public static property. public static Foo Something { get { Contract.Ensures(Contract.Result<Foo >() != null); Contract.Ensures(Contract.Result<Foo >().Bar == true); return something; } } private static readonly Foo something = new Foo(bar: true); Obviously I can't change "something" to "Something" because it will conflict. Using a different name for either will be inconsistent with instance property/fields. Also, I can't simply make it public because I'll lose the contracts. And contracts aren't the only reason that you may want to use this pattern.