SA1609 and internal properties

Apr 19, 2011 at 10:53 PM


Is there any reason why SA1609, once enabled, is not reported for internal properties?

Apr 20, 2011 at 2:16 PM


The code does this:

                // A missing value tag is only an error if this property is public or protected or protectedinternal.
                if (element.ActualAccess == AccessModifierType.Public ||
                   element.ActualAccess == AccessModifierType.ProtectedInternal || 
                   element.ActualAccess == AccessModifierType.Protected) 
                    this.AddViolation(element, Rules.PropertyDocumentationMustHaveValue);  


So, it only fires for public, protected, or protectedinternal. 

Apr 20, 2011 at 2:47 PM

IMO it is weird to treat properties in different ways based on their accessibility. Andy, do you know the rationale behind such implementation? Too many missing value tags for private and internal properties in Framework code?